No I don't have an infection, it's been the same for years really.
So I wash under my foreskin morning and night. Im uncircumcised.
It's not a horrendous smell but it's noticeable, when I go for a wee and take my pants down I get a whiff of a smell, is this normal? Am I maybe over washing it?